aa5e7f95

By: Michael Lynch <git@mtlynch.io>

Simplify upload handler after code review

- Drop duplicate CreateMediaItem; reuse existing InsertMediaItem.
- Reuse mediastore.WriteConverted for the full-size strip-and-write path
  instead of hand-rolled temp-file plumbing.
- Make MaxBytesReader the single photo-size limit and return a real 413
  on overflow; drop the unreachable byte-size check in NewProcessablePhoto.
- Inline the no-op NewFilename wrapper and collapse repeated file.Close()
  in parseUploadPostRequest; remove the now-redundant internal test
  (empty-filename rejection is covered in little_moments/media_test.go).
- Document the files-before-DB-row ordering choice.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Codeberg

Suite timing

Time to Start Worker time Duration Time to finish
Config 1s 1m06s 1m06s 1m08s
Eval 1m07s 2m11s 2m11s 3m19s
Build 1m25s 13m05s 4h26m37s 4h28m03s
Test - - - -
Deploy - - - -
Suite 1s 16m24s 4h28m01s 4h28m03s